Messages in this thread | | | Date | Fri, 09 Sep 2011 13:00:49 -0400 | From | Nitin Gupta <> | Subject | Re: [PATCH 1/5] Fix sparse warnings |
| |
On 09/08/2011 01:32 PM, Harvey Harrison wrote:
> On Thu, Sep 8, 2011 at 8:13 AM, Nitin Gupta <ngupta@vflare.org> wrote: >> On 09/08/2011 04:17 AM, Jerome Marchand wrote: >> >> Since it just fixes couple of trivial sparse warnings, >> I though no description is necessary? Anyways, here is >> the description if needed for patch process: >> >> Fixed some sparse warnings by making zram_slot_free_notify() >> static and max_zpage_size as size_t. >> > > Please just paste the exact sparse warnings you fixed with this patch, > then it will be more > understandable _why_ you made the above changes. >
new description:
Fixes sparse warning: zram_drv.c:666:6: warning: symbol 'zram_slot_free_notify' was not declared. Should it be static?
Also, max_zpage_size is now size_t just to be consistent with data-type of other variables maintaining sizes of various kinds.
Thanks, Nitin
| |