lkml.org 
[lkml]   [2011]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/10] Avoid dereferencing bd_disk during swap_entry_free for network storage
    On Fri, Sep 09, 2011 at 12:00:54PM +0100, Mel Gorman wrote:
    > Commit [b3a27d: swap: Add swap slot free callback to
    > block_device_operations] dereferences p->bdev->bd_disk but this is a
    > NULL dereference if using swap-over-NFS. This patch checks SWP_BLKDEV
    > on the swap_info_struct before dereferencing.

    Please just remove the callback entirely. It has no user outside the
    staging tree and was added clearly against the rules for that staging
    tree.

    (and it's butt ugly)



    \
     
     \ /
      Last update: 2011-09-09 15:05    [W:0.020 / U:151.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site