lkml.org 
[lkml]   [2011]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -V6 25/26] ext4: Implement rich acl for ext4
Date
Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> wrote:

> + retval = ext4_set_richacl(handle, inode, acl);
> + ext4_journal_stop(handle);
> + if (retval == ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries))
> + goto retry;

Should that be -ENOSPC?

I do wonder, why does ext4 need to know about richacls at all? Surely, as far
as ext4 is concerned, they should be seen as xattrs?

If ext4 needs a mark on disk to say it supports richacls, then why can't that
simply be the presence or lack thereof of a richacl on the root dir?

David


\
 
 \ /
  Last update: 2011-09-09 14:49    [W:0.209 / U:2.092 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site