lkml.org 
[lkml]   [2011]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -V6 09/26] vfs: Add delete child and delete self permission flags
Date
Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> wrote:

> + if ((error || is_sticky) && IS_RICHACL(inode) &&
> + !inode_permission(dir, mask & ~(MAY_WRITE | MAY_DELETE_CHILD)) &&
> + !inode_permission(inode, MAY_DELETE_SELF))
> + error = 0;

This might be easier to follow if you used == 0 rather than !. The problem
with ! is that it looks like:

not_have inode_permission.

I guess this is just one of the fun consequences of having 0 (false) meaning
okay.

David


\
 
 \ /
  Last update: 2011-09-09 12:15    [W:0.151 / U:6.728 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site