Messages in this thread | | | Date | Thu, 8 Sep 2011 10:26:35 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH] cleanup: no need to call rcu_lock in sock_update_classid() |
| |
On Mon, Sep 05, 2011 at 11:35:36PM -0300, Glauber Costa wrote: > There is no need to protect > > According to the all-knowing git log, this was inserted here to prevent a > warning in commit 1144182a. But 3fb5a991 also does that in a different place. > >From reading it, I believe they are fixing the same warning, so no need > for both.
Good catch!
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Glauber Costa <glommer@parallels.com> > CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > CC: Li Zefan <lizf@cn.fujitsu.com> > CC: David S. Miller <davem@davemloft.net> > --- > net/core/sock.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/net/core/sock.c b/net/core/sock.c > index bc745d0..3449df8 100644 > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -1107,9 +1107,7 @@ void sock_update_classid(struct sock *sk) > { > u32 classid; > > - rcu_read_lock(); /* doing current task, which cannot vanish. */ > classid = task_cls_classid(current); > - rcu_read_unlock(); > if (classid && classid != sk->sk_classid) > sk->sk_classid = classid; > } > -- > 1.7.6 >
| |