lkml.org 
[lkml]   [2011]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] cpufreq: pcc-cpufreq: sanity check to prevent a NULL pointer dereference
On Wed, 31 Aug 2011 20:08:45 +0000 (UTC)
Naga Chumbalkar <nagananda.chumbalkar@hp.com> wrote:

> If, for whatever reason, "pr" ends up being NULL we would end up in a PANIC
> as seen below:
>
> Loading CPUFreq modules[ 437.661360] BUG: unable to handle kernel NULL pointer
> dereference at (null)
> IP: [<ffffffffa0434314>] pcc_cpufreq_cpu_init+0x74/0x220 [pcc_cpufreq]
>
> It's better to prevent the PANIC by failing the driver, and allowing the system to boot.
>
> Signed-off-by: Naga Chumbalkar <nagananda.chumbalkar@hp.com>
> Cc: stable@kernel.org
>
> diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
> index 7b0603e..cdc02ac 100644
> --- a/drivers/cpufreq/pcc-cpufreq.c
> +++ b/drivers/cpufreq/pcc-cpufreq.c
> @@ -261,6 +261,9 @@ static int pcc_get_offset(int cpu)
> pr = per_cpu(processors, cpu);
> pcc_cpu_data = per_cpu_ptr(pcc_cpu_info, cpu);
>
> + if (!pr)
> + return -ENODEV;
> +
> status = acpi_evaluate_object(pr->handle, "PCCP", NULL, &buffer);
> if (ACPI_FAILURE(status))
> return -ENODEV;

hm, from reading drivers/acpi/processor_driver.c it appears that
per_cpu(processors, n)==NULL is an expected and valid state. Heaven
knows what that state actually *means* - apparently this is a secret.

I assume that you've hit this crash in real live code, hence your
suggestion of a -stable backport?



\
 
 \ /
  Last update: 2011-09-09 01:55    [W:0.047 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site