lkml.org 
[lkml]   [2011]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] Make PTRACE_SEIZE set ptrace options specified in 'data'
On 09/08, Denys Vlasenko wrote:
>
> Make PTRACE_SEIZE set ptrace options specified in 'data' parameter

Thanks, looks good. But we need the correct "Simplify PTRACE_foo..."
first.

> Make it possible to extend SEIZE in the future with more functionality
> by passing non-zero 'addr' parameter.

Agreed, this makes sense.

> Set all task->ptrace bits in one operation - before this change,
> we were adding PT_SEIZED and PT_PTRACE_CAP with task->ptrace |= BIT ops.
> This was probably ok (not a bug), but let's be on a safer side.

PT_PTRACE_CAP is fine, but PT_SEIZED is not really, afaics.

Oleg.



\
 
 \ /
  Last update: 2011-09-09 01:35    [W:0.067 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site