Messages in this thread | | | Date | Thu, 8 Sep 2011 08:29:47 +0800 | From | Wu Fengguang <> | Subject | Re: [PATCH 2/2] mm: Add comment explaining task state setting in bdi_forker_thread() |
| |
> grammar can often be fixed/improved by deleting stuff ;) > > --- a/mm/backing-dev.c~mm-add-comment-explaining-task-state-setting-in-bdi_forker_thread-fix > +++ a/mm/backing-dev.c > @@ -404,9 +404,8 @@ static int bdi_forker_thread(void *ptr) > /* > * In the following loop we are going to check whether we have > * some work to do without any synchronization with tasks > - * waking us up to do work for them. So we have to set task > - * state already here so that we don't miss wakeups coming > - * after we verify some condition. > + * waking us up to do work for them. Set the task state here > + * so that we don't miss wakeups after verifying conditions. > */ > set_current_state(TASK_INTERRUPTIBLE);
That's nice and readable, thanks!
Regards, Fengguang
| |