lkml.org 
[lkml]   [2011]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Simplify PTRACE_foo constants and PTRACE_SETOPTIONS code
Hello,

Mostly looks good to me. Just a small nit.

On Wed, Sep 07, 2011 at 11:36:37PM +0200, Denys Vlasenko wrote:
> static int ptrace_setoptions(struct task_struct *child, unsigned long data)
> {
> + unsigned flags;
>
> + if (data & ~(long)PTRACE_O_MASK) {

Can we use (unsigned long) here? Signed extensions have a nasty way
of sneaking up on you.

> + child->ptrace &= ~PT_TRACE_MASK; /* historical bug */

And it would be great if it explains what the historical bug was and
what the intended behavior is.

Other than that,

Acked-by: Tejun Heo <tj@kernel.org>

Thank you.

--
tejun


\
 
 \ /
  Last update: 2011-09-08 02:09    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog