lkml.org 
[lkml]   [2011]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v6 08/10] crc32-add-slicing-by-8.diff
    From
    Date
    Joakim Tjernlund/Transmode wrote on 2011/09/07 09:31:18:
    > > +# if CRC_LE_BITS == 32
    > > rem_len = len & 3;
    > > - /* load data 32 bits wide, xor data 32 bits wide. */
    > > len = len >> 2;
    > > +# else
    > > + rem_len = len & 7;
    > > + len = len >> 3;
    >
    > I still fail to see why this is needed. You still do 32 bit loads so this
    > only makes the code uglier, harder to maintain and makes small unaligned crc bufs
    > slower.

    Sorry, misread this part. Ignore it.

    Jocke



    \
     
     \ /
      Last update: 2011-09-07 18:53    [W:0.036 / U:0.100 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site