lkml.org 
[lkml]   [2011]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] lis3lv02d: Fix read() call in lis3lv02d_get_odr()
On Tue,  6 Sep 2011 00:12:28 -0700
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> The driver is passing a struct lis3lv02d ** to the read() operation but
> the read() operation wants a struct lis3lv02d * causing compiler warnings
> and presumably also runtime problems.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: stable@kernel.org
> ---
> drivers/misc/lis3lv02d/lis3lv02d.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/lis3lv02d.c
> index e67dcea..72a1f92 100644
> --- a/drivers/misc/lis3lv02d/lis3lv02d.c
> +++ b/drivers/misc/lis3lv02d/lis3lv02d.c
> @@ -200,7 +200,7 @@ static int lis3lv02d_get_odr(struct lis3lv02d *lis3)
> u8 ctrl;
> int shift;
>
> - lis3->read(&lis3, CTRL_REG1, &ctrl);
> + lis3->read(lis3, CTRL_REG1, &ctrl);
> ctrl &= lis3->odr_mask;
> shift = ffs(lis3->odr_mask) - 1;
> return lis3->odrs[(ctrl >> shift)];

This not applicable to mainline or to -stable. It is a fix to
lis3-remove-the-references-to-the-global-variable-in-core-driver.patch
which I already have queued, as
lis3-remove-the-references-to-the-global-variable-in-core-driver-fix.patch.


\
 
 \ /
  Last update: 2011-09-06 23:11    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog