lkml.org 
[lkml]   [2011]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] cfq: queued/in_driver stats
From
Jens,

>> The patch implements gathering and exporting statistics for cfqd->rq_queued
>> and cfqd->rq_in_driver. Average values of queued/in_driver are visible via
>> ...
> Seems like an awful lot of code for something that could be gleaned
> with blktrace?

I agree, from the view of keeping code simple, it's simpler to extend
existing blktrace logging like this:

- cfq_log_cfqq(cfqd, RQ_CFQQ(rq), "activate rq, drv=%d",
- cfqd->rq_in_driver);
+ cfq_log_cfqq(cfqd, RQ_CFQQ(rq), "activate rq, drv=%d queued=%d",
+ cfqd->rq_in_driver, cfqd->rq_queued);

and to print cfqd->hw_tag somewhere.

Thanks,
Maxim


\
 
 \ /
  Last update: 2011-09-05 10:39    [W:0.046 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site