Messages in this thread | | | Date | Mon, 5 Sep 2011 12:37:04 +0400 | Subject | Re: [PATCH v2] cfq: queued/in_driver stats | From | Maxim Patlasov <> |
| |
Jens,
>> The patch implements gathering and exporting statistics for cfqd->rq_queued >> and cfqd->rq_in_driver. Average values of queued/in_driver are visible via >> ... > Seems like an awful lot of code for something that could be gleaned > with blktrace?
I agree, from the view of keeping code simple, it's simpler to extend existing blktrace logging like this:
- cfq_log_cfqq(cfqd, RQ_CFQQ(rq), "activate rq, drv=%d", - cfqd->rq_in_driver); + cfq_log_cfqq(cfqd, RQ_CFQQ(rq), "activate rq, drv=%d queued=%d", + cfqd->rq_in_driver, cfqd->rq_queued);
and to print cfqd->hw_tag somewhere.
Thanks, Maxim
| |