Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] vfs: automount should ignore LOOKUP_FOLLOW | Date | Mon, 05 Sep 2011 17:37:39 +0100 |
| |
Miklos Szeredi <miklos@szeredi.hu> wrote:
> After 2.6.38, with the introduction of the ->d_automount() > infrastructure, stat(2) and others would start triggering automount > while lstat(2), etc. still would not. This is a regression and a > userspace ABI change.
It doesn't necessarily mean it's wrong. The main class of program that needs to be prevented from automounting are things that do bulk stat'ing (e.g. ls) - and they should probably be doing lstat() anyway.
> + /* We don't want to mount if someone's just doing a stat - > + * unless they're stat'ing a directory and appended a '/' to > + * the name.
Btw, line length is 80 chars. This comment could easily use one fewer line.
If you use emacs you can do:
ESC 7 9 C-x f
to set the right margin and then:
M-q
whilst the cursor is in the comment paragraph to be rearranged and it will 'fill' the paragraph to 79 characters.
David
| |