Messages in this thread | | | Date | Sun, 4 Sep 2011 12:13:05 +0800 | From | Wu Fengguang <> | Subject | Re: [PATCH 1/2] mm: Cleanup clearing of BDI_pending bit in bdi_forker_thread() |
| |
On Sun, Sep 04, 2011 at 11:04:42AM +0800, Wu Fengguang wrote: > On Sat, Sep 03, 2011 at 06:54:18AM +0800, Jan Kara wrote: > > bdi_forker_thread() clears BDI_pending bit at the end of the main loop. > > However clearing of this bit must not be done in some cases which is handled by > > calling 'continue' from switch statement. That's kind of unusual construct and > > without a good reason so change the function into more intuitive code flow. > > > > CC: Wu Fengguang <fengguang.wu@intel.com> > > CC: Andrew Morton <akpm@linux-foundation.org> > > Signed-off-by: Jan Kara <jack@suse.cz> > > It's pure code refactor. > > Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
But I do suspect it will slightly increase the code size. What do you think?
Thanks, Fengguang
| |