[lkml]   [2011]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCHv4] DMAEngine: Define interleaved transfer request api
    2011/10/1 Jassi Brar <>:
    > On 30 September 2011 12:13, Barry Song <> wrote:
    >> i support we can update dma_data_direction to:   MEM_TO_MEM,
    > So basically you are suggesting to replace 'enum dma_data_direction'
    > with 'enum xfer_direction'
    > I am not sure about that. I think they represent different things and
    > hence should be separate.
    > dma_data_direction tells the mapping of a buffer while the other
    > tells if the src and dst are memory or a device's FIFO.
    you are kind of right now. now people use dma_data_direction to do
    mapping for dma buffer. even with all 4 direction, people still use
    the old two direction to do mapping. For example, it can't use
    MEM_TO_MEM to map, it still need to know whether the memory is source
    or dest.

    i just don't like to the two old macro names. it seems i get a ticket
    flying from New York to Beijing, but actually, we fly to Mexico...
    so by the moment, dma_data_direction seems just to mean how to do map,
    but xfer_direction is the real transfer direction.

    How could we have two macro names: SRC_MEM, DEST_MEM for mapping. or just add:
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-10-01 05:09    [W:0.022 / U:157.720 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site