[lkml]   [2011]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always
On Fri, 30 Sep 2011 19:09:46 +0200, Daniel Vetter <> wrote:

> grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the
> dpms functions - any reasons these two writes are left out?

Upon a bit of review:

The bspec makes it clear that this write protect key only needs to
be written for eDP on DPA -- it's a work-around for a bug where panel
power sequencing wouldn't work right.

The LVDS code does disable write protect in the _init function, which
seems global enough, but misses the resume case. We shouldn't ever
need to set this field though; it write protects registers only
when the panel is running. We could presumably remove the
write protect disable entirely in the LVDS code.

So, I think the patch as written is correct.

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2011-10-01 01:17    [W:0.119 / U:3.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site