lkml.org 
[lkml]   [2011]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFCv2][PATCH 1/4] break units out of string_get_size()
From
Date
On Fri, 2011-09-30 at 14:29 -0700, H. Peter Anvin wrote:
> On 09/30/2011 01:32 PM, Dave Hansen wrote:
> > diff -puN lib/string_helpers.c~string_get_size-pow2 lib/string_helpers.c
> >
> > +const char *units_10[] = { "B", "kB", "MB", "GB", "TB", "PB",
> > + "EB", "ZB", "YB", NULL};
> > +const char *units_2[] = {"B", "KiB", "MiB", "GiB", "TiB", "PiB",
> > + "EiB", "ZiB", "YiB", NULL };
>
> These names are way too generic to be public symbols.

Ack, I managed to drop the static when I broke this out for the third
time. :)

> Another thing worth thinking about is whether or not the -B suffix
> should be part of these arrays.

... or the 'i' for that matter.

I'll give it a go.

-- Dave



\
 
 \ /
  Last update: 2011-10-01 00:49    [from the cache]
©2003-2011 Jasper Spaans