lkml.org 
[lkml]   [2011]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Intel-gfx] [PATCH 09/21] drm/i915: Delay DP i2c initialization until panel power timings are computed
    On Thu, Sep 29, 2011 at 06:09:41PM -0700, Keith Packard wrote:
    > On eDP, DDC requires panel power, but turning that on uses the panel
    > power sequencing timing values fetch from the DPCD data.
    >
    > Signed-off-by: Keith Packard <keithp@keithp.com>
    Can't really check more than what the patch does what it claims to do, so
    a weak:
    Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

    And a small question from the clueless: With your patch
    intel_dp_i2c_auch_ch checks whether panel or vdd is on, but I don't see
    where we turn that on and the drm dp i2c core seems to do a few
    transactions on setup time. Should we splatter a vdd_on/off around the
    i2c_init or is the panel guaranteed to have power at init time?
    -Daniel
    --
    Daniel Vetter
    Mail: daniel@ffwll.ch
    Mobile: +41 (0)79 365 57 48


    \
     
     \ /
      Last update: 2011-09-30 19:27    [W:0.019 / U:1.100 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site