Messages in this thread | | | Subject | Re: [PATCH RFC 7/8] s390/jump-label: add arch_jump_label_transform_early() | From | Jan Glauber <> | Date | Fri, 30 Sep 2011 16:48:19 +0200 |
| |
On Thu, 2011-09-29 at 16:26 -0700, Jeremy Fitzhardinge wrote: > From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > > This allows jump-label entries to be modified early, in a pre-SMP > environment. > > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > Cc: Jan Glauber <jang@linux.vnet.ibm.com>
Hi Jeremy,
Your patch looks fine, if you can fix the minor compiler warnings below. Excluding stop_machine() on pre-SMP also looks safer too me.
--Jan
CC arch/s390/kernel/jump_label.o arch/s390/kernel/jump_label.c: In function ‘__jump_label_transform’: arch/s390/kernel/jump_label.c:41:2: error: ‘rc’ undeclared (first use in this function) arch/s390/kernel/jump_label.c:41:2: note: each undeclared identifier is reported only once for each function it appears in arch/s390/kernel/jump_label.c:41:2: warning: passing argument 1 of ‘probe_kernel_write’ makes pointer from integer without a cast [enabled by default] include/linux/uaccess.h:108:21: note: expected ‘void *’ but argument is of type ‘jump_label_t’ arch/s390/kernel/jump_label.c:28:19: warning: unused variable ‘args’ [-Wunused-variable] make[2]: *** [arch/s390/kernel/jump_label.o] Error 1
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |