lkml.org 
[lkml]   [2011]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/20] drivers_base: platform: use always ->name for uevent
    Hi,

    On Mon, Aug 15, 2011 at 04:51:22PM +0200, Sebastian Andrzej Siewior wrote:
    > If id_entry is available then it is used. However if we remove first the
    > driver followed by the device, then the id_entry is pointing to driver's
    > memory which is long gone.
    > Since id->name and plat->name are equal there is no point in
    > distinguishing them.
    >
    > Cc: Greg Kroah-Hartman <gregkh@suse.de>
    > Cc: Grant Likely <grant.likely@secretlab.ca>
    > Cc: linux-kernel@vger.kernel.org
    > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    > ---
    > drivers/base/platform.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/base/platform.c b/drivers/base/platform.c
    > index 0cad9c7..cd71575 100644
    > --- a/drivers/base/platform.c
    > +++ b/drivers/base/platform.c
    > @@ -614,7 +614,7 @@ static int platform_uevent(struct device *dev, struct kobj_uevent_env *env)
    > return rc;
    >
    > add_uevent_var(env, "MODALIAS=%s%s", PLATFORM_MODULE_PREFIX,
    > - (pdev->id_entry) ? pdev->id_entry->name : pdev->name);
    > + pdev->name);
    > return 0;
    > }
    >

    Just a gentle reminder on this patch. Greg, has this one been queued to
    your drivers-core tree ? Should it go on -rc or now it's already too
    late and going on merge window ?

    thanks

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-09-30 15:31    [W:0.042 / U:31.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site