lkml.org 
[lkml]   [2011]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/24] Staging: hv: mousevsc: Fixup some bogus WARN_ON() calls
    Date
    Fix the bogus WARN_ON() calls.

    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
    ---
    drivers/staging/hv/hv_mouse.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
    index 69eb00e..016d7e5 100644
    --- a/drivers/staging/hv/hv_mouse.c
    +++ b/drivers/staging/hv/hv_mouse.c
    @@ -200,7 +200,7 @@ static struct mousevsc_dev *alloc_input_device(struct hv_device *device)

    static void free_input_device(struct mousevsc_dev *device)
    {
    - WARN_ON(atomic_read(&device->ref_count) == 0);
    + WARN_ON(atomic_read(&device->ref_count) != 0);
    kfree(device);
    }

    @@ -327,7 +327,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,

    /* Save the hid desc */
    desc = &device_info->hid_descriptor;
    - WARN_ON(desc->bLength > 0);
    + WARN_ON(desc->bLength == 0);

    input_device->hid_desc = kzalloc(desc->bLength, GFP_KERNEL);

    @@ -447,7 +447,7 @@ static void mousevsc_on_receive(struct hv_device *device,
    break;

    case SynthHidInitialDeviceInfo:
    - WARN_ON(pipe_msg->size >= sizeof(struct hv_input_dev_info));
    + WARN_ON(pipe_msg->size < sizeof(struct hv_input_dev_info));

    /*
    * Parse out the device info into device attr,
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-09-30 02:01    [W:0.019 / U:88.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site