lkml.org 
[lkml]   [2011]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/16] perf report: Fix stdio event name header printing
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    In the past we tried to avoid printing the name of the event when just
    one event was found in the perf.data file, after some refactorings it
    ended up not printing the event name if just one hist_entry was found in
    one of the events.

    Fix it by always printing the name of the event, even if just one is
    found.

    Reported-by: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/n/tip-kikr0c7ou55bd9caok8569rf@git.kernel.org
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-report.c | 5 +----
    1 files changed, 1 insertions(+), 4 deletions(-)

    diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
    index a0673ee..3d58334 100644
    --- a/tools/perf/builtin-report.c
    +++ b/tools/perf/builtin-report.c
    @@ -229,10 +229,7 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist,

    list_for_each_entry(pos, &evlist->entries, node) {
    struct hists *hists = &pos->hists;
    - const char *evname = NULL;
    -
    - if (rb_first(&hists->entries) != rb_last(&hists->entries))
    - evname = event_name(pos);
    + const char *evname = event_name(pos);

    hists__fprintf_nr_sample_events(hists, evname, stdout);
    hists__fprintf(hists, NULL, false, stdout);
    --
    1.6.2.5


    \
     
     \ /
      Last update: 2011-09-30 00:53    [W:0.020 / U:59.836 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site