Messages in this thread | | | Date | Thu, 29 Sep 2011 09:52:56 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC |
| |
On 9/28/2011 5:24 PM, Alim Akhtar wrote: > I did Modified pl08x_cctl_bits(), but for some reason i reverted it back. > what i was doing something like returning just __retbits__ instead of > retbits |= tsize << PL080_CONTROL_TRANSFER_SIZE_SHIFT; > and doing the below for the __non-s3c__ controllers in the > pl08x_fill_lli_for_desc(). > cctl |= 1 << PL080_CONTROL_TRANSFER_SIZE_SHIFT; > pl08x_fill_lli_for_desc(&bd, num_llis++, 1, cctl); >
One way out would be: Don't do retbits |= tsize << PL080_CONTROL_TRANSFER_SIZE_SHIFT in pl08x_cctl_bits() and do this conditionally in pl08x_fill_lli_for_desc(). This needs adding tsize argument in fill_lli_**() routine and removing it from cctl_bits().
Probably this is what you were mentioning.
-- viresh
| |