lkml.org 
[lkml]   [2011]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: Support driver probe deferral
On Thu, Sep 29, 2011 at 12:11:01PM +0100, Mark Brown wrote:
> If we fail to locate a requested regulator return -EAGAIN. If drivers
> pass this error code through to their caller (which they really should)
> then this will ensure that the probe is retried later when further devices
> become available.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Acked-by: Grant Likely <grant.likely@secretlab.ca>

Manjunath, can you add this to a series with the deferred probe patch?
You'll need to change the return code as discussed in the other
thread.

g.

> ---
>
> This depends on Grant's change to implement deferred probing, the error
> code for which is going to change in the next revision. Liam, if you're
> also OK with this change I propose that we both ack it and let it get
> carried along with the deferred probing change.
>
> drivers/regulator/core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index d5656b7..b39ec9f 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1154,7 +1154,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
> {
> struct regulator_dev *rdev;
> struct regulator_map *map;
> - struct regulator *regulator = ERR_PTR(-ENODEV);
> + struct regulator *regulator = ERR_PTR(-EAGAIN);
> const char *devname = NULL;
> int ret;
>
> @@ -2727,7 +2727,7 @@ struct regulator_dev *regulator_register(struct regulator_desc *regulator_desc,
> if (!found) {
> dev_err(dev, "Failed to find supply %s\n",
> init_data->supply_regulator);
> - ret = -ENODEV;
> + ret = -EAGAIN;
> goto scrub;
> }
>
> --
> 1.7.6.3
>


\
 
 \ /
  Last update: 2011-09-29 22:19    [W:0.033 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site