lkml.org 
[lkml]   [2011]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2 2/2] ARM: debug: Move DEBUG_ICEDCC into the DEBUG_LL choice
    On Thu, Sep 29, 2011 at 06:22:42PM +0100, Stephen Boyd wrote:
    > On 09/29/11 03:39, Will Deacon wrote:
    > > Agreed, software timing loops are the only option and it's impossible to get
    > > them right everywhere. I think the Kconfig help text should be updated so
    > > that the timeout paragraph is removed.
    >
    > Yes if you wait a long time the timeout for each character will expire
    > and the execution will continue.

    Well I got impatient, so I figured it was best to update the help text!

    > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
    > > index 32b1be4..bfdf86b 100644
    > > --- a/arch/arm/Kconfig.debug
    > > +++ b/arch/arm/Kconfig.debug
    > > @@ -81,6 +81,14 @@ choice
    > > prompt "Kernel low-level debugging port"
    > > depends on DEBUG_LL
    > >
    > > + config DEBUG_LL_UART_NONE
    > > + bool "No low-level debugging UART"
    >
    > Should this grow a long list of platforms that are in this choice menu?
    > For example:
    >
    > depends on !FOOTBRIDGE && !ARCH_CLPS711X && ...

    It might be nice to avoid that if we can. Once all the platforms have moved
    over to the choice, we can delete the dummy option anyway.

    > Otherwise
    >
    > Acked-by: Stephen Boyd <sboyd@codeaurora.org>

    Thanks,

    Will


    \
     
     \ /
      Last update: 2011-09-29 19:33    [W:0.022 / U:1.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site