lkml.org 
[lkml]   [2011]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 06/11] mm: memcg: remove optimization of keeping the root_mem_cgroup LRU lists empty
On Thu 29-09-11 11:20:33, Johannes Weiner wrote:
> On Tue, Sep 20, 2011 at 05:02:29PM +0200, Michal Hocko wrote:
> > On Mon 12-09-11 12:57:23, Johannes Weiner wrote:
> > > root_mem_cgroup, lacking a configurable limit, was never subject to
> > > limit reclaim, so the pages charged to it could be kept off its LRU
> > > lists. They would be found on the global per-zone LRU lists upon
> > > physical memory pressure and it made sense to avoid uselessly linking
> > > them to both lists.
> > >
> > > The global per-zone LRU lists are about to go away on memcg-enabled
> > > kernels, with all pages being exclusively linked to their respective
> > > per-memcg LRU lists. As a result, pages of the root_mem_cgroup must
> > > also be linked to its LRU lists again.
> >
> > Nevertheless we still do not charge them so this should be mentioned
> > here?
>
> Added for the next revision:
>
> "This is purely about the LRU list, root_mem_cgroup is still
> not charged."

OK, that should be more clear. Thanks!

--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic


\
 
 \ /
  Last update: 2011-09-29 11:51    [W:0.182 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site