lkml.org 
[lkml]   [2011]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[107/244] [SCSI] qla2xxx: Correct inadvertent loop state transitions during port-update handling.
    3.0-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Andrew Vasquez <andrew.vasquez@qlogic.com>

    commit 58b48576966ed0afd3f63ef17480ec12748a7119 upstream.

    Transitioning to a LOOP_UPDATE loop-state could cause the driver
    to miss normal link/target processing. LOOP_UPDATE is a crufty
    artifact leftover from at time the driver performed it's own
    internal command-queuing. Safely remove this state.

    Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
    Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/qla2xxx/qla_init.c | 3 ---
    drivers/scsi/qla2xxx/qla_isr.c | 1 -
    2 files changed, 4 deletions(-)

    --- a/drivers/scsi/qla2xxx/qla_init.c
    +++ b/drivers/scsi/qla2xxx/qla_init.c
    @@ -3822,15 +3822,12 @@ qla2x00_loop_resync(scsi_qla_host_t *vha
    req = vha->req;
    rsp = req->rsp;

    - atomic_set(&vha->loop_state, LOOP_UPDATE);
    clear_bit(ISP_ABORT_RETRY, &vha->dpc_flags);
    if (vha->flags.online) {
    if (!(rval = qla2x00_fw_ready(vha))) {
    /* Wait at most MAX_TARGET RSCNs for a stable link. */
    wait_time = 256;
    do {
    - atomic_set(&vha->loop_state, LOOP_UPDATE);
    -
    /* Issue a marker after FW becomes ready. */
    qla2x00_marker(vha, req, rsp, 0, 0,
    MK_SYNC_ALL);
    --- a/drivers/scsi/qla2xxx/qla_isr.c
    +++ b/drivers/scsi/qla2xxx/qla_isr.c
    @@ -736,7 +736,6 @@ skip_rio:
    vha->flags.rscn_queue_overflow = 1;
    }

    - atomic_set(&vha->loop_state, LOOP_UPDATE);
    atomic_set(&vha->loop_down_timer, 0);
    vha->flags.management_server_logged_in = 0;




    \
     
     \ /
      Last update: 2011-09-29 01:07    [W:4.151 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site