lkml.org 
[lkml]   [2011]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[004/244] sfi: table irq 0xFF means no interrupt
    3.0-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>

    commit a94cc4e6c0a26a7c8f79a432ab2c89534aa674d5 upstream.

    According to the SFI specification irq number 0xFF means device has no
    interrupt or interrupt attached via GPIO.

    Currently, we don't handle this special case and set irq field in
    *_board_info structs to 255. It leads to confusion in some drivers.
    Accelerometer driver tries to register interrupt 255, fails and prints
    "Cannot get IRQ" to dmesg.

    Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Signed-off-by: Alan Cox <alan@linux.intel.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86/platform/mrst/mrst.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/arch/x86/platform/mrst/mrst.c
    +++ b/arch/x86/platform/mrst/mrst.c
    @@ -689,7 +689,9 @@ static int __init sfi_parse_devs(struct
    irq_attr.trigger = 1;
    irq_attr.polarity = 1;
    io_apic_set_pci_routing(NULL, pentry->irq, &irq_attr);
    - }
    + } else
    + pentry->irq = 0; /* No irq */
    +
    switch (pentry->type) {
    case SFI_DEV_TYPE_IPC:
    /* ID as IRQ is a hack that will go away */



    \
     
     \ /
      Last update: 2011-09-29 00:43    [W:0.033 / U:1.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site