lkml.org 
[lkml]   [2011]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] spinlock: rm duplicated preempt en/disable for bottom half
From
Date
On Tue, 2011-09-27 at 15:56 +0800, Bob Liu wrote:
> local_bh_en/disable() has already deal with en/disable preempt, so rm the
> dumplicated one from spinlock_api_up/smp.h head file.

I bet you haven't tried booting this.. you just broke stuff like:

spin_lock_bh(&foo);
/* do crap */
spin_unlock(&foo);
/* do some other crap */
local_bh_enable();


And yes that does happen.




\
 
 \ /
  Last update: 2011-09-27 11:17    [W:0.034 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site