Messages in this thread | | | Subject | Re: [PATCH] spinlock: rm duplicated preempt en/disable for bottom half | From | Peter Zijlstra <> | Date | Tue, 27 Sep 2011 11:13:56 +0200 |
| |
On Tue, 2011-09-27 at 15:56 +0800, Bob Liu wrote: > local_bh_en/disable() has already deal with en/disable preempt, so rm the > dumplicated one from spinlock_api_up/smp.h head file.
I bet you haven't tried booting this.. you just broke stuff like:
spin_lock_bh(&foo); /* do crap */ spin_unlock(&foo); /* do some other crap */ local_bh_enable();
And yes that does happen.
| |