Messages in this thread | | | Date | Tue, 27 Sep 2011 20:21:10 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH][RT] ring-buffer: Convert reader_lock from raw_spin_lock into spin_lock |
| |
On Tue, 27 Sep 2011, Steven Rostedt wrote: > + /* > + * If an NMI die dumps out the content of the ring buffer > + * do not grab locks. We also permanently disable the ring > + * buffer too. A one time deal is all you get from reading > + * the ring buffer from an NMI. > + */ > + if (!ok_to_lock()) { > + if (spin_trylock_irqsave(&cpu_buffer->reader_lock, *flags)) > + return 1; > + printk("Dumping ring buffer from unsafe context\n"); > + printk("Disabling new ring buffer writes\n");
And what exaclty is the point of these printks/ Aside of that they are missing KERN_WTF before the string.
Thanks,
tglx
| |