Messages in this thread Patch in this message | | | From | Amit Nagal <> | Subject | [PATCH 1/1] HID: hidraw: open count should not increase if error | Date | Tue, 27 Sep 2011 13:41:58 -0400 |
| |
In hidraw_open, if hid_hw_power returns with error, hidraw device open count should not increase.
Signed-off-by: Amit Nagal <helloin.amit@gmail.com> --- drivers/hid/hidraw.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index c841a8e..09bbcc9 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -271,8 +271,10 @@ static int hidraw_open(struct inode *inode, struct file *file) dev = hidraw_table[minor]; if (!dev->open++) { err = hid_hw_power(dev->hid, PM_HINT_FULLON); - if (err < 0) + if (err < 0) { + dev->open--; goto out_unlock; + } err = hid_hw_open(dev->hid); if (err < 0) { -- 1.7.7-rc0
| |