lkml.org 
[lkml]   [2011]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: S4 resume broken since 2.6.39 (3.1, too)
    On Mon, Sep 26, 2011 at 3:24 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
    >
    > So, in my opinion we should simply apply the Takashi's patch at this
    > point and revisit the kdump issue later, when we actually know how to do
    > the right thing.

    Applying that trivial patch certainly looks fine, especially since it
    also avoids some arbitrary differences between x86-64 and x86-32.

    That said, the whole code looks *very* confusing, and I have to say
    that the commit logs there are also totally unreadable and not very
    explanatory at all.

    It does seem like the code is simply buggy: it "allocates" the page
    tables from the end of memory, but it seems to want to do that before
    they have been mapped. Which makes perfect sense, since the whole
    point of allocating them is to be *able* to map all the memory.

    So using that

    good_end = max_pfn_mapped << PAGE_SHIFT;

    would seem to be a good idea regardless. I'm not sure how the old code
    is even supposed to work. That said - why is this a problem only for
    S4 resume?

    Yinghai?

    Linus


    \
     
     \ /
      Last update: 2011-09-27 00:49    [W:4.112 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site