Messages in this thread | | | Date | Mon, 26 Sep 2011 09:32:31 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 4/7] nohz: Allow rcu extended quiescent state handling seperately from tick stop |
| |
On Mon, Sep 26, 2011 at 06:06:47PM +0200, Peter Zijlstra wrote: > On Mon, 2011-09-26 at 09:02 -0700, Paul E. McKenney wrote: > > Would your readability concerns be addressed by something like the > > following? > > > > #define RCU_NO_HZ_LATER 0 > > #define RCU_NO_HZ_NOW 1 > > > > Then we would have one of the following: > > > > tick_nohz_idle_enter(RCU_NO_HZ_LATER); > > tick_nohz_idle_enter(RCU_NO_HZ_NOW); > > That certainly is a lot better, except for the two different ways of > collating NO HZ in that one line.
So perhaps RCU_NOHZ_LATER and RCU_NOHZ_NOW?
Though currently the Linux kernel drops the underscore for lower-case "nohz" and keeps it for upper-case "NO_HZ". Hey, it was that way when I started messing with it many years ago! ;-)
Thanx, Paul
| |