Messages in this thread | | | Date | Mon, 26 Sep 2011 10:56:11 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 01/11] MFD: DA9052/53 MFD core module v6 |
| |
On Mon, Sep 19, 2011 at 06:03:16PM +0530, ashishj3 wrote: > The DA9052/53 is a highly integrated PMIC subsystem with supply domain flexibility > to support wide range of high performance application. > > It provides voltage regulators, GPIO controller, Touch Screen, RTC, Battery > control and other functionality.
So, this looks good. However...
> +static struct regmap_config da9052_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > +}; > + > +static int da9052_spi_probe(struct spi_device *spi)
...having reviewed previous versions of your driver I believe you need to set either or both of read_flag_mask or write_flag_mask your regmap config (these have been added in -next) - previous versions of your driver had code which was trying to bodge this in, you've removed this code but not added any use of the generic facility so I rather suspect that currently the driver doesn't work with SPI.
Samuel, as a fix will depend on -next regmap I guess it makes sense for me to apply this if a new version is provided before the next merge window?
| |