lkml.org 
[lkml]   [2011]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] kernel.h: rename pack_hex_byte to hex_pack_byte
On Fri, 23 Sep 2011 13:47:26 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> As suggested by Andrew Morton in [1] there is better to have most significant
> part first in the function name.
>
> [1] https://lkml.org/lkml/2011/9/20/22
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> include/linux/kernel.h | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index 46ac9a5..5022158 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -374,13 +374,18 @@ extern const char hex_asc[];
> #define hex_asc_lo(x) hex_asc[((x) & 0x0f)]
> #define hex_asc_hi(x) hex_asc[((x) & 0xf0) >> 4]
>
> -static inline char *pack_hex_byte(char *buf, u8 byte)
> +static inline char *hex_byte_pack(char *buf, u8 byte)
> {
> *buf++ = hex_asc_hi(byte);
> *buf++ = hex_asc_lo(byte);
> return buf;
> }
>
> +static inline char * __deprecated pack_hex_byte(char *buf, u8 byte)
> +{
> + return hex_byte_pack(buf, byte);
> +}
> +

err, no thanks. That's just going to hit everyone with great
screenfuls of compile warnings while waiting for someone else to fix
them up.



\
 
 \ /
  Last update: 2011-09-23 22:21    [from the cache]
©2003-2011 Jasper Spaans