lkml.org 
[lkml]   [2011]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 04/10] drbd: Replace and remove old primitives
Hi!

On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner@linbit.com> wrote:
> From: Andreas Gruenbacher <agruen@linbit.com>
>
> Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
> ---
>  drivers/block/drbd/drbd_int.h      |   45 +----
>  drivers/block/drbd/drbd_main.c     |  502 ++++++++++++++++--------------------
>  drivers/block/drbd/drbd_receiver.c |   86 ++++---
>  drivers/block/drbd/drbd_worker.c   |   24 +-
>  4 files changed, 294 insertions(+), 363 deletions(-)

I'm afraid this commit is waaaaay too large and complicated
to have a one-line commit message.
You should either split this up into more pieces or you should
write a detailed log indicated what this is supposed to be doing
and why it is OK. (Or both).

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-09-23 19:37    [from the cache]
©2003-2011 Jasper Spaans