Messages in this thread | | | Subject | Re: [PATCH 0/3] Replace kmalloc with vmalloc in seq_files | From | Peter Zijlstra <> | Date | Thu, 22 Sep 2011 23:22:49 +0200 |
| |
On Thu, 2011-09-22 at 13:57 -0700, Colin Cross wrote: > > seq_files are often used for debugging data. When the system is under > memory pressure, and dumping debugging data starts trying to allocate > large physically contiguous buffers, it often makes the problem > worse.
Shouldn't you be using ->next instead of dumping everything in a single seqop? That way it can return partial buffers and keep state etc.
| |