lkml.org 
[lkml]   [2011]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] efi: Avoid sysfs spew on reboot and panic
于 2011/9/21 20:40, Matthew Garrett 写道:
> On Wed, Sep 21, 2011 at 11:31:40AM +0800, Chen Gong wrote:
>>> mutex_lock(&psinfo->buf_mutex);
>>> memcpy(psinfo->buf, buf, size);
>>> - id = psinfo->write(type, 0, size, psinfo);
>>> + id = psinfo->write(type, 0, KMSG_DUMP_UNKNOWN, size, psinfo);
>>
>> I can't say it is wrong because no real caller for this function, but I can't
>> say it is right, yet. KMSG_DUMP_UNKNOWN here looks too arbirary. Do you have
>> any reason to use this type here ?
>
> If a function calls pstore_write() directly then we have no type to
> associate with it. It seems worth making this explicit.
>

Yep, that's the point. We hope to get a more reasonable method to do it, not
any assumption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-09-22 04:25    [W:0.067 / U:16.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site