lkml.org 
[lkml]   [2011]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH V10 5/6] mm: cleancache: update to match akpm frontswap feedback
> From: Konrad Wilk
>
> On Thu, Sep 15, 2011 at 02:34:46PM -0700, Dan Magenheimer wrote:
> > From: Dan Magenheimer <dan.magenheimer@oracle.com>
> > Subject: [PATCH V10 5/6] mm: cleancache: update to match akpm frontswap feedback
>
> That is a pretty bad title. Think about it - in a year, you are going to
> try to track down something using 'git annotate' and this git commit is going
> to come up. And you look at it and this is the title. It does not carry
> the technical details of what is in the patch.
>
> Also in case you are thinking "But there are so more git commits" - don't
> fret about them. It is OK to have many of them. So don't by shy with them.

OK, thanks for the feedback. Since there are no code changes,
I won't flood the list with another version with the patches divided
differently (and thanks for your help reorganizing them and your offlist
review so I know it meets your approval!); instead I will just make a
new v11 git branch. Since kernel.org is still down, if anyone
wants to look at the latest, it can be found at:

git://oss.oracle.com/git/djm/tmem.git#frontswap-v11

I'll also be asking Stephen Rothwell to pull v11 into linux-next
because the frontswap version that is there is getting a bit stale.

Hopefully everything is finally now ready for merging for the
3.2 window!

Thanks,
Dan


\
 
 \ /
  Last update: 2011-09-21 21:17    [W:0.047 / U:1.328 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site