Messages in this thread |  | | Subject | Re: [PATCH V3] mtd: Add DiskOnChip G3 support | | From | Artem Bityutskiy <> | | Date | Wed, 21 Sep 2011 09:08:07 +0300 |
| |
On Tue, 2011-09-20 at 17:44 +0200, Robert Jarzmik wrote: > Artem Bityutskiy <dedekind1@gmail.com> writes: > > > I really feel unsure about merging this driver because no one reviewed > > it. On the surface it does look neat, though. Could you please CC lkml > > on next submission? > OK, when we have covered your comments, I'll report a V4 to lkml as well. > > > On Mon, 2011-09-19 at 19:43 +0200, Robert Jarzmik wrote: > >> +static void doc_delay(struct docg3 *docg3, int nbNOPs) > >> +{ > >> + int i; > >> + > >> + doc_dbg("NOP x %d\n", nbNOPs); > >> + for (i = 0; i < nbNOPs; i++) > >> + doc_writeb(0, DoC_NOP); > >> +} > > > > Why you implement dalaying this way, instead of using udelay/mdelay? > That's from observation, as I have no specification available. > > From my understanding, the clock applied to the chip can be variable, but the > memory bus writes ensure the necessary time, as the NOP write takes as much time > as the DOCG3 decides it to last.
OK, would be nice to have this kind of comment in that function.
> >> + }; > > > > Hmm, looks like something which should be generic, not DoC-specific. > True, but it's not available yet. > And as it's not available, and I don't think debugfs will accept such a patch, I > think I'll leave it here. And if you wish, I'll fill in a separate patch to > debugfs, and *if* it's merged, I'll remove that part then.
Fine with me.
-- Best Regards, Artem Bityutskiy
|  |