[lkml]   [2011]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/1] Trivial: devtmpfsd: Setting task running/interruptible states
On Wed, Sep 21, 2011 at 09:09:33PM +0530, Kautuk Consul wrote:
> This trivial patch makes the following changes in devtmpfsd() :

This is not the definition of "trivial" in that you are changing the
logic of the code, not just doing spelling changes.

> - Set the state to TASK_INTERRUPTIBLE using __set_current_state
> instead of set_current_state as the spin_unlock is an implicit
> memory barrier.

Why? What is this hurting with the original code?

> - After return from schedule(), there is no need to set the current
> state to TASK_RUNNING as the wake_up_process() function call will
> do this for us.

Are you sure?

Have you tested this patch and everything works properly?

greg k-h

 \ /
  Last update: 2011-09-21 18:03    [W:0.039 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site