Messages in this thread | | | Date | Wed, 21 Sep 2011 08:54:44 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/1] Trivial: devtmpfsd: Setting task running/interruptible states |
| |
On Wed, Sep 21, 2011 at 09:09:33PM +0530, Kautuk Consul wrote: > This trivial patch makes the following changes in devtmpfsd() :
This is not the definition of "trivial" in that you are changing the logic of the code, not just doing spelling changes.
> - Set the state to TASK_INTERRUPTIBLE using __set_current_state > instead of set_current_state as the spin_unlock is an implicit > memory barrier.
Why? What is this hurting with the original code?
> - After return from schedule(), there is no need to set the current > state to TASK_RUNNING as the wake_up_process() function call will > do this for us.
Are you sure?
Have you tested this patch and everything works properly?
greg k-h
| |