lkml.org 
[lkml]   [2011]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 55/57] hexagon: irq: Remove IRQF_DISABLED
Thanks!  I already had that timer fixed in my tree, but I had left out the
IPI flag. I will make sure this goes into the next patch series.


Thanks again,
Richard Kuo


On Wed, Sep 21, 2011 at 05:28:56PM +0800, Yong Zhang wrote:
> Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
> We run all interrupt handlers with interrupts disabled
> and we even check and yell when an interrupt handler
> returns with interrupts enabled (see commit [b738a50a:
> genirq: Warn when handler enables interrupts]).
>
> So now this flag is a NOOP and can be removed.
>
> Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
> ---
> arch/hexagon/kernel/smp.c | 2 +-
> arch/hexagon/kernel/time.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/hexagon/kernel/smp.c b/arch/hexagon/kernel/smp.c
> index 96bf6c2..ad43649 100644
> --- a/arch/hexagon/kernel/smp.c
> +++ b/arch/hexagon/kernel/smp.c
> @@ -136,7 +136,7 @@ void send_ipi(const struct cpumask *cpumask, enum ipi_message_type msg)
>
> static struct irqaction ipi_intdesc = {
> .handler = handle_ipi,
> - .flags = IRQF_DISABLED | IRQF_TRIGGER_RISING,
> + .flags = IRQF_TRIGGER_RISING,
> .name = "ipi_handler"
> };
>
> diff --git a/arch/hexagon/kernel/time.c b/arch/hexagon/kernel/time.c
> index fc8e95c..a4d7b58 100644
> --- a/arch/hexagon/kernel/time.c
> +++ b/arch/hexagon/kernel/time.c
> @@ -181,7 +181,7 @@ static irqreturn_t timer_interrupt(int irq, void *devid)
> /* This should also be pulled from devtree */
> static struct irqaction rtos_timer_intdesc = {
> .handler = timer_interrupt,
> - .flags = IRQF_DISABLED | IRQF_TIMER | IRQF_TRIGGER_RISING,
> + .flags = IRQF_TIMER | IRQF_TRIGGER_RISING,
> .name = "rtos_timer"
> };
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


\
 
 \ /
  Last update: 2011-09-21 17:37    [W:0.136 / U:27.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site