[lkml]   [2011]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver
On Wed, Sep 21, 2011 at 09:28:30AM +0200, Corentin Chary wrote:
> On Tue, Sep 20, 2011 at 11:55 PM, Seth Forshee
> <> wrote:
> > Changes toshiba_acpi to register an acpi driver and eliminates the
> > platform device it was using.
> Why to you want to remove the platform device ? If you want to create
> a sysfs interface later, you'll probably need it. Most of the platform
> driver I know only use the acpi_device to send proc/netlink events and
> the platform_device is used everywhere else. (And anyway, it's an x86
> *platform* driver, not a pure acpi driver).

I removed the platform device because it seems a bit redundant to have
both, and I don't see what benefit it really provides. I see your point
that conceptually it makes sense to have it has a platform device,
although the distinction there is pretty fine.

Anyway, I guess the cost of keeping the platform device in place is
pretty small, so I can add it back in if that's desirable.

> > Also eliminates most global
> > variables, moving them into toshiba_acpi_dev, along with some
> > other miscellaneous fixes and cleanup.
> Good ! Next step would be to deprecate the /proc interface (keeping it
> for compatibility) and adding a new shinny
> /sys/platform/device/toshiba-acpi/ interface correctly documented in
> Documentation/ABI/ :).

I was avoiding chainging any userspace interfaces in this first round of
patches, but deprecating the proc interface is definitely something I'd
like to do. I don't know if there's any point to moving it to sysfs
though. Most of it already has sysfs interfaces via device classes, and
I don't know that there's any value in the rest of it.


 \ /
  Last update: 2011-09-21 15:27    [W:0.049 / U:89.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site