Messages in this thread | | | Date | Wed, 21 Sep 2011 14:09:40 +0200 | From | Jens Axboe <> | Subject | Re: xen_biovec_phys_mergeable not exported |
| |
On 2011-09-20 22:25, Matthew Wilcox wrote: > > In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE(). If CONFIG_XEN > is defined, it references xen_biovec_phys_mergeable() which is not > EXPORT_SYMBOL. I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing > to be calling from a module that implements a bio-based block driver, > so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to > the Xen code when I submit the driver. > > Does anyone have a different opinion on this?
Yep, lets just export it for now. Long term, that functionality will be moving back into the block layer when we unify the queuing models.
-- Jens Axboe
| |