lkml.org 
[lkml]   [2011]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel
On Mon, 19 Sep 2011 15:22:00 -0700
Keith Packard <keithp@keithp.com> wrote:

> The eDP panel may not be able to respond to aux channel communications
> unless it has power supplied. During mode setting, power may be
> cut-off during panel power sequencing. Make sure that any aux channel
> communications will work by forcing vdd power active as needed.
>
> This also delays after turning power on and off to ensure that the
> panel is keeping up.
>
> Signed-off-by: Keith Packard <keithp@keithp.com>

This one mixes up lots of cleanups plus the EDID read with the power
changes. I'm worried about the VDD smashing as well; we have lots of
bugs in the PPS hardware around VDD vs full PPS. We need to make sure
appropriate delays are in place when transitioning from one to another.

In what paths are we trying to do accesses without power applied?
Looks like mainly edid?

I see the next patch handles the timing stuff, I assume it's ok.

Jesse


\
 
 \ /
  Last update: 2011-09-21 05:53    [W:0.147 / U:6.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site