lkml.org 
[lkml]   [2011]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3.1.0-rc4-tip 0/26] Uprobes patchset with perf probe support
* Christoph Hellwig <hch@infradead.org> [2011-09-20 10:28:43]:

> On Tue, Sep 20, 2011 at 07:42:04PM +0530, Srikar Dronamraju wrote:
> > I could use any other inode/file/mapping based sleepable lock that is of
> > higher order than mmap_sem. Can you please let me know if we have
> > alternatives.
>
> Please do not overload unrelated locks for this, but add a specific one.
>
> There's two options:
>
> (a) add it to the inode (conditionally)
> (b) use global, hashed locks
>
> I think (b) is good enough as adding/removing probes isn't exactly the
> most critical fast path.
>

Agree, I will replace the i_mutex with a uprobes specific hash locks.
I will make this change as part of next patchset.

--
Thanks and Regards
Srikar



\
 
 \ /
  Last update: 2011-09-20 17:43    [W:0.094 / U:0.308 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site