Messages in this thread | | | Date | Tue, 20 Sep 2011 16:20:31 +0200 | From | Johannes Weiner <> | Subject | Re: [RFC][PATCH 3/5] memcg: Disable preemption in memcg_check_events() |
| |
On Mon, Sep 19, 2011 at 05:20:43PM -0400, Steven Rostedt wrote: > From: Steven Rostedt <srostedt@redhat.com> > > The code in memcg_check_events() calls this_cpu_read() on > different variables without disabling preemption, and can cause > the calculations to be done from two different CPU variables. > > Disable preemption throughout the check to keep apples and oranges > from becoming a mixed drink.
Makes sense, thanks!
Since the atomic versions are no longer required with preemption disabled explicitely, could you also make the this_cpu ops in __memcg_event_check and __mem_cgroup_target_update non-atomic in the same go?
| |