lkml.org 
[lkml]   [2011]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 1/5] lib: add unpack_hex_byte()
On Tue, 20 Sep 2011 09:04:00 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Tue, Sep 20, 2011 at 1:38 AM, Andrew Morton <akpm@google.com> wrote:
> >> > Finally, the name is poor. __It starts with "unpack_", so it belongs to
> >> > the "unpack" subsystem. __There's no such thing. __Something like
> >> > hex_byte_to_bin() would be better.
> >>
> >> agreed. __It was suppose to parallel the existing pack_hex_byte().
> >
> > hex_byte_pack() :)
> Have you just proposed to do mass rename of pack_hex_byte() to the
> hex_byte_pack()?

It's very minor, but I suppose we should, if someone feels like it.

We should retain a

char * __deprecated pack_hex_byte(char *buf, u8 byte)
{
return hex_byte_pack(buf, byte);
}
for a few cycles to minimise harm to out-of-tree code.


\
 
 \ /
  Last update: 2011-09-20 08:27    [from the cache]
©2003-2011 Jasper Spaans