lkml.org 
[lkml]   [2011]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] user namespace: usb: make usb urbs user namespace aware
    Quoting Oleg Nesterov (oleg@redhat.com):
    > On 09/19, Serge E. Hallyn wrote:
    > >
    > > Add to the dev_state and alloc_async structures the user namespace
    > > corresponding to the uid and euid. Pass these to kill_pid_info_as_uid(),
    > > which can then implement a proper, user-namespace-aware uid check.
    >
    > IOW, we add the additional "user_namespace *" member/argument, and use
    > it along with uid/euid.
    >
    > I am not really sure, but can't we simplify this?
    >
    > > @@ -68,6 +69,7 @@ struct dev_state {
    > > wait_queue_head_t wait; /* wake up if a request completed */
    > > unsigned int discsignr;
    > > struct pid *disc_pid;
    > > + struct user_namespace *user_ns;
    > > uid_t disc_uid, disc_euid;
    >
    > Can't we add "const struct cred *disc_cred" and kill disc_uid/disc_euid
    > instead?
    >
    > Then we redefine kill_pid_info_as_uid() as kill_pid_info_as_cred(...cred...),
    > it can use cred->cred->uid/euid directly.
    >
    > devio.c does get_cred/put_cred instead of get_user_ns/put_user_ns.
    >
    > What do you think?

    Yeah, just as file->f_cred does. Sounds good.

    I'll re-send both these patches with your suggestions applied. Thanks!

    -serge


    \
     
     \ /
      Last update: 2011-09-20 15:35    [W:0.020 / U:94.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site