[lkml]   [2011]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRe: [PATCH] staging: iio: light: Fix compiler warning in tsl2563.c
    > Don't overwrite the error code.  For example, the lower layers can
    > return -EAGAIN and that's more useful than just returning -EIO every
    > time.
    Ahh.. Thanks a lot for explaining this.

    > Your fix works, but it's not very clean. Just add a "*id = ret;"
    > line before the "return 0;" and that's it. (It doesn't make sense
    > to pass a pointer to "id" and not use it).
    Dan, yes, I agree with you. This fix is much much better than what I
    had in my mind.

    > Yikes - I wonder why my various compilers don't throw that up.
    I guess, in "iio-blue.git" tree, the 'id = 0' suppresses this warning.

    Signed-off-by: Maxin B. John <>
    diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
    index f25243b..55012ff 100644
    --- a/drivers/staging/iio/light/tsl2563.c
    +++ b/drivers/staging/iio/light/tsl2563.c
    @@ -226,7 +226,7 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id)
    ret = i2c_smbus_read_byte_data(client, TSL2563_CMD | TSL2563_REG_ID);
    if (ret < 0)
    return ret;
    + *id = ret;
    return 0;

     \ /
      Last update: 2011-09-02 11:43    [W:0.019 / U:148.436 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site